Bump cellmapper_scvi's base image and align both obsm keys - #53
Merged
Conversation
rcannood
force-pushed
the
fix/cellmapper-scvi-key-and-pin
branch
from
July 29, 2026 17:43
e441c39 to
6b38233
Compare
8 tasks
The 1.0.0 tag is on python 3.10, which caps cellmapper at 0.2.3, and
0.2.3 builds the map_obsm key as f"{key}_{prediction_postfix}" -- so the
"_pred" postfix gave mod2__pred and the component KeyError'd on every
run. The sliding :1 tag is on 3.12 and installs 0.2.6, which builds the
key without the extra underscore.
* Bump cellmapper_scvi to openproblems/base_pytorch_nvidia:1
* Require cellmapper>=0.2.6 in both components
* Switch cellmapper_linear to the same "_pred" postfix, so both read
obsm["mod2_pred"]
rcannood
force-pushed
the
fix/cellmapper-scvi-key-and-pin
branch
from
July 30, 2026 06:43
6b38233 to
dcdfec9
Compare
rcannood
commented
Jul 30, 2026
Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
cellmapper_scvifails on every run on currentmain:This is my fault -- #23 was wrong. I checked cellmapper's GitHub
maininstead of the version the image actually installs. Sorry for the churn.What's really going on
cellmapper changed how
map_obsmnames its output key, and the two cellmapper components were on different sides of that change because of their base images:f"{key}_{prediction_postfix}"f"{key}{prediction_postfix}"cellmapper_scvipinnedopenproblems/base_pytorch_nvidia:1.0.0, which is on Python 3.10 -- and 0.2.4+ requires ≥3.11 (0.2.6 requires ≥3.12), so pip there could only ever resolve 0.2.3:On 0.2.3 the
"_pred"postfix yieldsmod2__pred, hence the KeyError.The change
Rather than pinning the component down to 0.2.3, bump the base image --
:1.0.0was the only non-sliding base image left in the repo, everything else already uses:1, and:1is on Python 3.12:cellmapper_scvi: base image:1.0.0->:1. The existingprediction_postfix="_pred"is then correct, so the script is untouched.cellmapper_linear: switch to the same"_pred"postfix, so both components readobsm["mod2_pred"].cellmapper>=0.2.6. An open>=0.2.2makes the correct key depend on when the image was built, which is how this slipped through twice.The bumped image also picks up current versions of everything else:
Verified on a de.NBI Tesla T4
Rebuilt both images from scratch (
---setup cb) and ran them, samplingnvidia-smi --query-compute-appsonce a second:Both images confirmed on
cellmapper 0.2.6.cellmapper_scvinow produces a valid prediction and genuinely uses the GPU -- as far as I can tell it has never produced a score before this.Found while checking on de.NBI which GPU-labelled methods actually use the GPU.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!